Fix off-by-one in pem_find_pattern rejecting PEM without a trailing newline - #11259
Merged
Conversation
|
Can one of the admins verify this patch? |
gasbytes
force-pushed
the
pem-parser-new-line
branch
from
August 25, 2026 17:41
380cdda to
48a29f1
Compare
gasbytes
marked this pull request as ready for review
August 25, 2026 17:41
|
retest this please |
Contributor
Author
|
Jenkins retest this please (logs lost) |
gasbytes
force-pushed
the
pem-parser-new-line
branch
from
August 26, 2026 10:23
48a29f1 to
7e054bc
Compare
Contributor
Author
|
Jenkins retest this please (timeout) |
1 similar comment
Contributor
Author
|
Jenkins retest this please (timeout) |
wolfSSL-Fenrir-bot
previously requested changes
Aug 26, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11259
Scan targets checked: wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
philljj
self-requested a review
August 26, 2026 20:59
Contributor
|
skoll locally ran clean, no comments. |
philljj
requested changes
Aug 26, 2026
…he footers's final dash
gasbytes
force-pushed
the
pem-parser-new-line
branch
from
August 27, 2026 12:28
7e054bc to
a71e104
Compare
Contributor
Author
|
Jenkins retest this please |
1 similar comment
Contributor
Author
|
Jenkins retest this please |
philljj
self-requested a review
August 28, 2026 13:37
philljj
approved these changes
Aug 28, 2026
philljj
dismissed
wolfSSL-Fenrir-bot’s stale review
August 28, 2026 14:18
changes addressed, skoll runs clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed both scans loops in pem_find_pattern to <= so PEM ending at the footer's final dash parses.
Testing
Updated the general test test_wolfssl_pem_read to test this edge case too.
Checklist